Aryan SinghandClaude Opus 5 0ebc9515b4 Try the whole ladder, rather than five eighths of it ...

MAX_ATTEMPTS was 5 while CANDIDATES was 8, so three ranked candidates were
gathered and then never tried. The cap was arbitrary and the live numbers show
what it cost.

slskd answers 500 whenever it cannot open a connection to a peer, and that is
common: retrying "Michael Jackson - Billie Jean" walked four unreachable peers
before the fifth served it -- succeeding on precisely the last attempt the cap
allowed. "The Weeknd - Die For You" ran the same gauntlet and lost, giving up
with three untried candidates still on the row.

Defaults to CANDIDATES, so the ladder is the ladder. Anyone wanting the old
behaviour can still set MUSE_MAX_ATTEMPTS.

The cap test lowers the value explicitly now; with the two equal by default it
was only ever proving the list ran out, which is the other branch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

0ebc9515b4 · 2026-09-02 11:59:52 -05:00

History

..

test_acquisition.py

Try the whole ladder, rather than five eighths of it

2026-09-02 11:59:52 -05:00

test_authz.py

Fix a path traversal out of the music library

2026-08-05 01:45:41 -05:00

test_invites.py

Bind invites to a provider, and email them

2026-08-05 12:05:44 -05:00

test_matching.py

Add review, discover, email; rebuild the design system

2026-08-05 02:10:33 -05:00

test_security.py

Fix a path traversal out of the music library

2026-08-05 01:45:41 -05:00